fix(OpenApiType): Prevent arrays indexed by non-strings #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
No you can not.
|
|
Right I checked, it results in |
|
Anything against merging this? |
nickvergessen
approved these changes
Jul 23, 2024
provokateurin
deleted the
fix/openapitype/prevent-non-string-indexed-arrays
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON objects can only be indexed by string, so any other type has to be prevented.
In theory we could parse
array<int, ...>as simple JSON array, but that is very likely not the intended use since there is no way to skip int keys in JSON and thusarray<...>orlist<...>should be used.For reference: nextcloud/tables#1169